Add negative leak test for iOS #6449
Conversation
niklasberglund
force-pushed
the
iOS-negative-leak-tests
branch
from
45b5c0e to
dc55447
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/MullvadVPNUITests/Networking/StreamCollection.swift line 160 at r1 (raw file):
} return DateInterval(start: startDate!, end: endDate!)
Left some illegal force unwrapping in this function which should probably be fixed 👮
There was a problem hiding this comment.
Reviewable status: 0 of 13 files reviewed, 2 unresolved discussions (waiting on @pinkisemils)
ios/MullvadVPNUITests/Base/BaseUITestCase.swift line 110 at r1 (raw file):
let springboard = XCUIApplication(bundleIdentifier: "com.apple.springboard") if springboard.buttons["Allowi"].waitForExistence(timeout: Self.shortTimeout) {
Typo "Allowi"
There was a problem hiding this comment.
Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @pinkisemils)
ios/MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved line 0 at r1 (raw file):
Restore 😄
Add a negative leak test. This is a draft PR. The implementation should almost be there, but the main issue with the test right now seems to be that
getConnectedThroughRelayDateIntervalis returning a longer date interval for the relay connection than expected. I believe its a bug in the test code but it could also be that the stored data is incorrect. Had to work with stored data because of the ongoing move.To try it out run
testNegativeLeaksunderLeakTests. The test device must be connected to theapp-team-ios-testsWiFi to be able to reach the packet capture API and firewall API.This change is